Repository navigation
Conversation
zollqir
added
documentation
Xmader
self-requested a review
March 27, 2023 14:56
Xmader
requested changes
Mar 27, 2023
Co-authored-by: Tom Wenzheng Tang <xmader@outlook.com>
Co-authored-by: Tom Wenzheng Tang <xmader@outlook.com>
Co-authored-by: Tom Wenzheng Tang <xmader@outlook.com>
Co-authored-by: Tom Wenzheng Tang <xmader@outlook.com>
Co-authored-by: Tom Wenzheng Tang <xmader@outlook.com>
Xmader
approved these changes
Mar 29, 2023
Member
|
LGTM |
This was referenced Feb 12, 2024
This was referenced Aug 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the following two tickets
Return function wrappers from bifrost2.eval https://distributive.atlassian.net/jira/software/c/projects/BF2/issues/BF2-15
Implement basic Python->JS argument coercion https://distributive.atlassian.net/jira/software/c/projects/BF2/issues/BF2-16
It also updates the README to more accurately represent the build process